Support DNSSEC + DANE #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Are you still interested in seeing this merged? If so, please rebase this set and we can get the ball going. |
added 3 commits
February 17, 2016 15:33
That adds the ARES_FLAG_DNSSEC flag, which enables the extensions needed for the server to send a DNSSEC reply.
That flag ensures that if DNSSEC is not used in the reply, and the AD bit is not set, then the query will fail with ARES_ENODNSSEC.
This adds ares_parse_tlsa_reply().
Author
|
Done. |
|
Any word on whether this will be merged soon? |
Member
|
Does it work good for you? Getting feedback or comments on work helps us assess them. Right now it also seems to conflict so that would be neat to see fixed. |
|
Sadly my knowledge of DNSSEC is extremely limited so I wouldn't be able to speak with any authority on whether it's functioning as needed. There seems to be significantly less code for DNSSEC related functionality in comparison with ldns, but again my lack of DNSSEC understanding makes it difficult to determine if this would be a problem or not. Sorry :/ |
Author
|
No longer interested in pursuing that. |
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of patches adds support for DNSSEC + parsing of DANE structures.
Changes:
To add support for sending a query that will set the flags needed by dnssec I had to add the new ares_create_query2().
These patches do add raw DNSSEC support and DANE. They do not add support for reading the trusted dnssec servers (done as separate pull requests).