ares_gethostbyname: fake hostent for AF_UNSPEC#204
Merged
Conversation
Currently, the conditional which decides whether the specified host is an IPv4 address verifies whether family is AF_INET or AF_INET6 which is equivalent to saying family is AF_UNSPEC, but users of AF_UNSPEC cannot fake IPv4 hosts.
Contributor
Author
|
The reason the coverage has fallen by 0.002% is because the if checking for IPv4 addresses is no longer executed for family == AF_INET6, which is nonsensical anyways. |
sergepetrenko
pushed a commit
to tarantool/c-ares
that referenced
this pull request
Jul 29, 2022
…-ares#204) fake_hostent() was not supporting AF_UNSPEC, so when an ip address was specified when using AF_UNSPEC it would attempt to do a DNS lookup rather than returning a fake hostent using the ip address. Fix By: Seraphime Kirkovski (@Seraphime)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the conditional which decides whether the specified host
is an IPv4 address verifies whether family is AF_INET or AF_INET6
which is equivalent to saying family is AF_UNSPEC, but users of
AF_UNSPEC cannot fake IPv4 hosts.