Fix: sizeof(sizeof(addr.saX)) -> sizeof(addr.saX) in readaddrinfo#331
Merged
bradh352 merged 1 commit intoc-ares:masterfrom May 12, 2020
Merged
Fix: sizeof(sizeof(addr.saX)) -> sizeof(addr.saX) in readaddrinfo#331bradh352 merged 1 commit intoc-ares:masterfrom
bradh352 merged 1 commit intoc-ares:masterfrom
Conversation
sergepetrenko
pushed a commit
to tarantool/c-ares
that referenced
this pull request
Jul 29, 2022
…ares#331) Looks like a sed-gone-wrong, a sizeof inside of a sizeof. Fix By: Ivan Baidakou (@basiliscos)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it always returns 8 bytes (x64 architecture), so bind
memcpy(dest, ai->ai_addr, ai->ai_addrlen)is buggy, and instead of relying onai_addrlenfield,ai_addrshould be examined for type before copying; the last approach is a workaround, of course.