Avoid overflow in RC4 loop comparison#336
Merged
bradh352 merged 1 commit intoc-ares:masterfrom Jul 2, 2020
fionn:equal-width-comparison
Merged
Avoid overflow in RC4 loop comparison#336bradh352 merged 1 commit intoc-ares:masterfrom fionn:equal-width-comparison
bradh352 merged 1 commit intoc-ares:masterfrom
fionn:equal-width-comparison
Conversation
The rc4 function iterates over a buffer of size buffer_len who's maximum value is INT_MAX with a counter of type short that is not guaranteed to have maximum size INT_MAX. In circumstances where short is narrower than int and where buffer_len is larger than the maximum value of a short, it may be possible to loop infinitely as counter will overflow and never be greater than or equal to buffer_len. The solution is to make the comparison be between types of equal width. This commit defines counter as an int.
sergepetrenko
pushed a commit
to tarantool/c-ares
that referenced
this pull request
Jul 29, 2022
The rc4 function iterates over a buffer of size buffer_len who's maximum value is INT_MAX with a counter of type short that is not guaranteed to have maximum size INT_MAX. In circumstances where short is narrower than int and where buffer_len is larger than the maximum value of a short, it may be possible to loop infinitely as counter will overflow and never be greater than or equal to buffer_len. The solution is to make the comparison be between types of equal width. This commit defines counter as an int. Fix By: Fionn Fitzmaurice (@fionn)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rc4function iterates over a buffer of sizebuffer_lenwho's maximumvalue is
INT_MAXwith a counter of typeshortthat is not guaranteed tohave maximum size
INT_MAX.In circumstances where
shortis narrower thanintand wherebuffer_lenis larger than the maximum value of a
short, it may be possible to loopinfinitely as
counterwill overflow and never be greater than or equalto
buffer_len.The solution is to make the comparison be between types of equal width.
This commit defines
counteras anint.