Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg source tree #349

Merged
merged 50 commits into from Sep 9, 2020
Merged

Reorg source tree #349

merged 50 commits into from Sep 9, 2020

Conversation

bradh352
Copy link
Member

@bradh352 bradh352 commented Sep 8, 2020

@bagder started a project a couple of years ago to reorganize the source tree. I've now attempted to do this myself. There should be quite a few similarities with #123

@bradh352 bradh352 requested a review from bagder September 8, 2020 15:53
@coveralls
Copy link

coveralls commented Sep 8, 2020

Coverage Status

Coverage remained the same at 88.743% when pulling 3682a35 on bradh352:reorg into abe1ff1 on c-ares:master.

@bradh352 bradh352 merged commit 0bf721c into c-ares:master Sep 9, 2020
0 of 2 checks passed
@bradh352 bradh352 deleted the reorg branch September 9, 2020 11:44
daviddrysdale added a commit to daviddrysdale/oss-fuzz that referenced this pull request Sep 11, 2020
Upstream c-ares/c-ares#349 re-organized the
c-ares source tree, so update build.sh to find things in their new
places.

Also remove the CFLAGS workaround, which seems to be no longer needed
(and also seems to result in a malformed test/Makefile being generated).
daviddrysdale added a commit to daviddrysdale/oss-fuzz that referenced this pull request Sep 11, 2020
Upstream c-ares/c-ares#349 re-organized the
c-ares source tree, so update build.sh to find things in their new
places.

Also remove the CFLAGS workaround, which seems to be no longer needed
(and also seems to result in a malformed test/Makefile being generated).

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25566
daviddrysdale added a commit to daviddrysdale/oss-fuzz that referenced this pull request Sep 11, 2020
Upstream c-ares/c-ares#349 re-organized the
c-ares source tree, so update build.sh to find things in their new
places.

Also remove the CFLAGS workaround, which seems to be no longer needed
(and also seems to result in a malformed test/Makefile being generated).

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25566
inferno-chromium pushed a commit to google/oss-fuzz that referenced this pull request Sep 11, 2020
* [c-ares] Update build script for upstream changes

Upstream c-ares/c-ares#349 re-organized the
c-ares source tree, so update build.sh to find things in their new
places.

Also remove the CFLAGS workaround, which seems to be no longer needed
(and also seems to result in a malformed test/Makefile being generated).

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25566

* [c-ares] Disable dataflow config

Has link errors due to #3388
apolcyn added a commit to apolcyn/grpc that referenced this pull request Apr 12, 2021
BethGriggs added a commit to BethGriggs/node that referenced this pull request Aug 3, 2021
c-ares refactored their source tree in 1.17.0 which we did not apply in
our update to 1.17.1. This commit syncs our source with their new
structure for easier maintenance going forward.

Refs: c-ares/c-ares#349
Refs: nodejs#36207
BethGriggs added a commit to BethGriggs/node that referenced this pull request Aug 4, 2021
c-ares refactored their source tree in 1.17.0 which we did not apply in
our update to 1.17.1. This commit syncs our source with their new
structure for easier maintenance going forward.

Refs: c-ares/c-ares#349
Refs: nodejs#36207
BethGriggs added a commit to BethGriggs/node that referenced this pull request Aug 5, 2021
c-ares refactored their source tree in 1.17.0 which we did not apply in
our update to 1.17.1. This commit syncs our source with their new
structure for easier maintenance going forward. cares.gyp is updated
accordingly.

Refs: c-ares/c-ares#349
Refs: nodejs#36207
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Aug 6, 2021
PR-URL: #39653
Refs: c-ares/c-ares#349
Refs: #36207
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Aug 6, 2021
c-ares refactored their source tree in 1.17.0 which we did not apply in
our update to 1.17.1. This commit syncs our source with their new
structure for easier maintenance going forward. cares.gyp is updated
accordingly.

Refs: c-ares/c-ares#349
Refs: #36207

PR-URL: #39653
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
PR-URL: nodejs#39653
Refs: c-ares/c-ares#349
Refs: nodejs#36207
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
c-ares refactored their source tree in 1.17.0 which we did not apply in
our update to 1.17.1. This commit syncs our source with their new
structure for easier maintenance going forward. cares.gyp is updated
accordingly.

Refs: c-ares/c-ares#349
Refs: nodejs#36207

PR-URL: nodejs#39653
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
sergepetrenko pushed a commit to tarantool/c-ares that referenced this pull request Jul 29, 2022
Originally started by Daniel Stenberg (@bagder) with c-ares#123, this patch reorganizes the c-ares source tree to have a more modern layout.  It also fixes out of tree builds for autotools, and automatically builds the tests if tests are enabled.  All tests are passing which tests each of the supported build systems (autotools, cmake, nmake, mingw gmake).  There may be some edge cases that will have to be caught later on for things I'm not aware of.

Fix By: Brad House (@bradh352)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants