Skip to content

Safeguard against empty hquery->name #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2020
Merged

Safeguard against empty hquery->name #367

merged 1 commit into from
Oct 21, 2020

Conversation

lmarszal
Copy link
Contributor

If hquery->name is empty (=="\0"), &hquery->name[strlen(hquery->name)-1] would point to "random" place in memory. This is causing some of my address sanitizer tests to fail.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.625% when pulling 01fe50e on lmarszal:empty-strings into 4d6975b on c-ares:master.

@bradh352 bradh352 merged commit c15f403 into c-ares:master Oct 21, 2020
@lmarszal lmarszal deleted the empty-strings branch October 21, 2020 12:43
sergepetrenko pushed a commit to tarantool/c-ares that referenced this pull request Jul 29, 2022
@lmarszal @sergepetrenko
empty hquery->name could lead to invalid memory access (c-ares#367)
db0683a 
If hquery->name is empty (=="\0"), &hquery->name[strlen(hquery->name)-1] would point to "random" place in memory. This is causing some of my address sanitizer tests to fail.

Fix By: Łukasz Marszał (@lmarszal)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lmarszal @coveralls @bradh352