Skip to content

Make install work also on iOS #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Conversation

anton-danielsson
Copy link
Contributor

Fixes:

INSTALL TARGETS given no BUNDLE DESTINATION for MACOSX_BUNDLE executable

The usefulness of these binaries on iOS can be discussed but it helps if the build "just works".
In my case this change will help to exclude special handling when using c-ares trough
the Conan package manager.

Fixes:
INSTALL TARGETS given no BUNDLE DESTINATION for MACOSX_BUNDLE executable
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.619% when pulling e4cc623 on DiracResearch:ios-install-fix into a7231d7 on c-ares:master.

@bradh352 bradh352 merged commit ca34b35 into c-ares:master Feb 16, 2021
@anton-danielsson anton-danielsson deleted the ios-install-fix branch February 16, 2021 11:31
sergepetrenko pushed a commit to tarantool/c-ares that referenced this pull request Jul 29, 2022
INSTALL TARGETS were missing the BUNDLE DESTINATION

Fix By: Anton Danielsson (@anton-danielsson)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants