CMake: RANDOM_FILE not defined#397
Merged
Merged
Conversation
…ng, rename to CARES_RANDOM_FILE.
sergepetrenko
pushed a commit
to tarantool/c-ares
that referenced
this pull request
Jul 29, 2022
RANDOM_FILE was never defined by cmake, causing RC4 key generation to use the less secure rand() method. Also, due to clashes with chain-building from other projects (e.g. curl) that may define RANDOM_FILE, this was renamed to CARES_RANDOM_FILE. This is the proposed change for c-ares#396 Fix By: Brad House (@bradh352)
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this pull request
May 26, 2023
Upstream c-ares renamed `RANDOM_FILE` to `CARES_RANDOM_FILE` some time ago in c-ares 1.17.2. PR-URL: #48156 Refs: c-ares/c-ares#397 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
May 30, 2023
Upstream c-ares renamed `RANDOM_FILE` to `CARES_RANDOM_FILE` some time ago in c-ares 1.17.2. PR-URL: #48156 Refs: c-ares/c-ares#397 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
denihs
pushed a commit
to meteor/node-v14-esm
that referenced
this pull request
Jun 22, 2023
Upstream c-ares renamed `RANDOM_FILE` to `CARES_RANDOM_FILE` some time ago in c-ares 1.17.2. PR-URL: nodejs#48156 Refs: c-ares/c-ares#397 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
erikolofsson
pushed a commit
to Malterlib/node
that referenced
this pull request
Jun 26, 2023
Upstream c-ares renamed `RANDOM_FILE` to `CARES_RANDOM_FILE` some time ago in c-ares 1.17.2. PR-URL: nodejs#48156 Refs: c-ares/c-ares#397 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
erikolofsson
pushed a commit
to Malterlib/node
that referenced
this pull request
Jun 26, 2023
Upstream c-ares renamed `RANDOM_FILE` to `CARES_RANDOM_FILE` some time ago in c-ares 1.17.2. PR-URL: nodejs#48156 Refs: c-ares/c-ares#397 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
denihs
pushed a commit
to meteor/node-v14-esm
that referenced
this pull request
Jul 3, 2023
Upstream c-ares renamed `RANDOM_FILE` to `CARES_RANDOM_FILE` some time ago in c-ares 1.17.2. PR-URL: nodejs#48156 Refs: c-ares/c-ares#397 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Upstream c-ares renamed `RANDOM_FILE` to `CARES_RANDOM_FILE` some time ago in c-ares 1.17.2. PR-URL: nodejs#48156 Refs: c-ares/c-ares#397 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Upstream c-ares renamed `RANDOM_FILE` to `CARES_RANDOM_FILE` some time ago in c-ares 1.17.2. PR-URL: nodejs#48156 Refs: c-ares/c-ares#397 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Feb 18, 2025
Upstream c-ares renamed `RANDOM_FILE` to `CARES_RANDOM_FILE` some time ago in c-ares 1.17.2. PR-URL: nodejs#48156 Refs: c-ares/c-ares#397 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
m0th3rch1p
pushed a commit
to m0th3rch1p/node
that referenced
this pull request
Jul 20, 2025
Upstream c-ares renamed `RANDOM_FILE` to `CARES_RANDOM_FILE` some time ago in c-ares 1.17.2. PR-URL: nodejs#48156 Refs: c-ares/c-ares#397 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RANDOM_FILE was never defined by cmake, causing RC4 key generation to use the less secure rand() method.
Also, due to clashes with chain-building from other projects (e.g. curl) that may define RANDOM_FILE, this was renamed to CARES_RANDOM_FILE.
This is the proposed change for #396