Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for URI(Uniform Resource Identifier) records. #411

Merged
merged 7 commits into from Aug 10, 2021

Conversation

martin-256
Copy link
Contributor

I'm finishing work from pull request #389 created by my former colleague https://github.com/Prasek-prtes.

Added tests and forgotten adjustments.

@bradh352 bradh352 mentioned this pull request Jul 28, 2021
Copy link
Member

@bradh352 bradh352 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at a cursory glance, the only issue I see is the headers mentioned in the review

#ifdef HAVE_ARPA_NAMESER_COMPAT_H
# include <arpa/nameser_compat.h>
#endif

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just include ares_nameser.h always, and never directly include arpa/nameser.h or arpa/nameser_compat.h ... see c2f3235 on this change we made to the rest of c-ares

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I didn't notice this change.

@bradh352
Copy link
Member

I'll merge this after the 1.17.2 release which is just about out.

@bradh352 bradh352 merged commit 9ac7efc into c-ares:master Aug 10, 2021
sergepetrenko pushed a commit to tarantool/c-ares that referenced this pull request Jul 29, 2022
Add ares_parse_uri_reply() for parsing URI DNS replies.

Fix By: Martin Holeš (@martin-256)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants