Added support for URI(Uniform Resource Identifier) records.#411
Merged
bradh352 merged 7 commits intoc-ares:masterfrom Aug 10, 2021
Merged
Added support for URI(Uniform Resource Identifier) records.#411bradh352 merged 7 commits intoc-ares:masterfrom
bradh352 merged 7 commits intoc-ares:masterfrom
Conversation
This commit adds a parser for URI reply and extending adig utility for query URI resource records.
Closed
bradh352
reviewed
Jul 28, 2021
Member
bradh352
left a comment
bradh352
left a comment
There was a problem hiding this comment.
at a cursory glance, the only issue I see is the headers mentioned in the review
| #ifdef HAVE_ARPA_NAMESER_COMPAT_H | ||
| # include <arpa/nameser_compat.h> | ||
| #endif | ||
|
|
Member
There was a problem hiding this comment.
Please just include ares_nameser.h always, and never directly include arpa/nameser.h or arpa/nameser_compat.h ... see c2f3235 on this change we made to the rest of c-ares
Contributor
Author
There was a problem hiding this comment.
Thank you. I didn't notice this change.
Member
|
I'll merge this after the 1.17.2 release which is just about out. |
sergepetrenko
pushed a commit
to tarantool/c-ares
that referenced
this pull request
Jul 29, 2022
Add ares_parse_uri_reply() for parsing URI DNS replies. Fix By: Martin Holeš (@martin-256)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm finishing work from pull request #389 created by my former colleague https://github.com/Prasek-prtes.
Added tests and forgotten adjustments.