use strncasecmp in ares__strsplit #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code used a custom solution with #ifdef CPP directives. The logic in strncasecmp is more thorough, and it is preferred. There are also two more minor fixes: 1) A space is added between a control flow keyword its parenthesis, to match the style elsewhere in the file. 2) The included headers are cleaned up; ares_private.h includes all the relevant private header functions (such as ares__strsplit and strncasecmp)
don't get rid of parens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code used a custom solution with #ifdef CPP directives. The logic in strncasecmp is more thorough, and it is preferred.
There are also two more minor fixes:
match the style elsewhere in the file.
the relevant private header functions (such as ares__strsplit and
strncasecmp)