-
Notifications
You must be signed in to change notification settings - Fork 634
Update from 1989 MIT license text to modern MIT license text #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hrm, this may not be proper as MIT apparently was the original source of ares which c-ares was a fork of, so it should stay in the copyright of any files containing any original source. That may be extremely hard to determine at this point, of course. I'm pretty sure we can actually place both copyrights in each file, legally, as different parts of the code may contain code written by different authors under different copyrights. @bagder I really think we should move forward in some regard on this, at least any newly created code should be under the newer version of the license, so anything I've written I can authorize such a change. And if you'd let me change anything with your specific copyright I can do that too. Anything else, we'll probably need to do the "dual" license method so we don't violate anyone's rights. |
The original ares MIT license seems to be the Old Style (no advertising without permission). But I can't find any SPDX identifier for this. It seems I was wrong to set it to For anything that has my copyright we can just as well switch to the canonical MIT license version. The original ares was written by Greg Hudson. Maybe we can reach out to him and see what he has to say. He at least used to be ghudson at MIT.EDU twenty years ago... |
Looks like he might be on github too :) @greghudson are you the same Greg Hudson that was the original "ares" author? If so, can you comment on licensing? We would like to move away from the 1989 MIT license for c-ares to the currently recognized MIT license. We would also need to know if "MIT" needs to be maintained as one of the copyright holders, or if you personally are the copyright holder. |
I am the original author of ares. It was a work-for-hire (I wrote it as an employee of MIT, which I still am), so the copyright is owned by MIT. I am not sure what the "currently recognized MIT license" refers to, but I can authorize a switch to a 2-clause BSD license like MIT uses for current MIT krb5:
|
@greghudson The current license is identical to https://fedoraproject.org/wiki/Licensing:MIT#Old_Style_(no_advertising_without_permission)
We would like to update it to https://opensource.org/license/mit/ (https://spdx.org/licenses/MIT.html)
While I don't have a problem with the 2-clause BSD license you said you could approve, that just adds to license sprawl that I'm trying to address here. Can you approve the switch to this MIT license referenced above? NOTE: edited new license to fit within 80-character lines. |
@greghudson, not sure if this is relevant, but I did find this page: Which says:
...
So we're looking to transfer to the only "Preferred" option on that page :) |
Sure, if the MIT TLO currently recommends that as the preferred license, I'm happy to authorize that as well. |
@greghudson awesome, thank you. I'll get this PR fixed up to properly provide attribution to MIT where relevant under the current MIT license text. |
Andrew Selivanov (@ki11roy), Christian Ammer (@ChristianAmmer), John Schember (@user-none), Gisle Vanem (@gvanem), Jakub Hrozek (@jhrozek), Daniela Sonnenschein (@lxdicted), Jérémy Lal (@kapouer), Marko Kreen (@markokr) : You all have been identified as having provided significant contributions to c-ares in the past and are listed as copyright holders in one or more files in c-ares. We are trying to update the MIT license version used in c-ares from the 1989 variant: We would appreciate confirmation (or decline) from each of the above listed contributors to re-license your contributions under the newer text. Please reply to this ticket. Thanks! |
Yes, go ahead. |
Dominick Meglio (@dcmeglio), do we have your permission as well to update to the latest MIT license text? |
Sure. No problem |
Sure. Go ahead guys.
…On Tue, Oct 3, 2023 at 3:44 AM dcmeglio ***@***.***> wrote:
Dominick Meglio ***@***.*** <https://github.com/dcmeglio>), do we have
your permission as well to update to the latest MIT license text?
Sure. No problem
—
Reply to this email directly, view it on GitHub
<#556 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN2MZXTNQIQH2QUFYVZ3BTX5NNXXAVCNFSM6AAAAAA5LAM6VWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBTHE4DMNJVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Best regards,
Andrew
|
I'm good with the change. |
Great, that leaves acknowledgements needed from Christian Ammer (@ChristianAmmer), Gisle Vanem (@gvanem), Jakub Hrozek (@jhrozek), Daniela Sonnenschein (@lxdicted), and Marko Kreen (@markokr) |
Sure, fine for me. |
BTW I don't really remember how I got my name into it. My contribution is so small, that I'd rather waive my rights to c-ares, if I had any :) That'll make one less people to ask when it comes to it ! |
Fine by me. |
Fine. Go ahead. |
I'm ok with relicensing any and all of my contributions to cares |
@jhrozek, we'll only be changing the version of the MIT license in use. You'll still be attributed. |
Due to not having valid contact information for Daniela Sonnenschein (@lxdicted) -- both email addresses I have bounced, I have put both license blocks on At this point, I've received confirmation from every author who directly contributed to c-ares and put their name in a copyright header, so I think this PR is on solid legal grounds. |
- Fix CVE-2024-21892, CVE-2024-22019, CVE-2024-21896, CVE-2024-22017, CVE-2023-46809, CVE-2024-21891, CVE-2024-21890 and CVE-2024-22025 - LICENSE hash changed due to two things: * c-ares vendored dependency license got updated [1]. This is unused by buildroot though anyway * base64 vendored library license updated copyright years and sorted contributor names [2], [3] - This bump will fix the following build failure raised since bump of python to version 3.12.1 in commit 36e635d thanks to nodejs/node@95534ad nodejs/node@6557c1c: Traceback (most recent call last): File "/home/autobuild/autobuild/instance-2/output-1/build/host-nodejs-src-20.9.0/configure.py", line 17, in <module> from distutils.version import StrictVersion ModuleNotFoundError: No module named 'distutils' https://github.com/nodejs/node/blob/v20.11.1/CHANGELOG.md [1] c-ares/c-ares#556 [2] aklomp/base64@2e8ad2a [3] aklomp/base64@d7bca2b Fixes: 36e635d - http://autobuild.buildroot.org/results/8b38bc4b7879a0349c1305e2fcb458a0cfd04a93 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Reviewed-By: Marcus Hoffmann <buildroot@bubu1.eu> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
- Fix CVE-2024-21892, CVE-2024-22019, CVE-2024-21896, CVE-2024-22017, CVE-2023-46809, CVE-2024-21891, CVE-2024-21890 and CVE-2024-22025 - LICENSE hash changed due to two things: * c-ares vendored dependency license got updated [1]. This is unused by buildroot though anyway * base64 vendored library license updated copyright years and sorted contributor names [2], [3] - This bump will fix the following build failure raised since bump of python to version 3.12.1 in commit 36e635d thanks to nodejs/node@95534ad nodejs/node@6557c1c: Traceback (most recent call last): File "/home/autobuild/autobuild/instance-2/output-1/build/host-nodejs-src-20.9.0/configure.py", line 17, in <module> from distutils.version import StrictVersion ModuleNotFoundError: No module named 'distutils' https://github.com/nodejs/node/blob/v20.11.1/CHANGELOG.md [1] c-ares/c-ares#556 [2] aklomp/base64@2e8ad2a [3] aklomp/base64@d7bca2b Fixes: 36e635d - http://autobuild.buildroot.org/results/8b38bc4b7879a0349c1305e2fcb458a0cfd04a93 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Reviewed-By: Marcus Hoffmann <buildroot@bubu1.eu> Signed-off-by: Peter Korsgaard <peter@korsgaard.com> (cherry picked from commit 02ecb09) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
While fixing c-ares#556 some files were missed.
While fixing c-ares#556 and re-licensing to the new MIT license text some files were forgotten to be updated.
Inconsistent MIT license verbiage. Some files used non-standard license text.
This update standardizes all instances to use the current recognized MIT license text.