Repository navigation
Fix building c-ares-1.22.0 and higher under Watcom. - #623
Merged
Merged
Conversation
Contributor
Author
|
The two CI fails are unrelated (connections to deb.debian.org timed out) |
This commit fixes building c-ares using the WATCOM compiler by adding -dHAS_STDINT_H into the CFLAGS. On a configure or CMake based configuration, this would be added in by that process. This fixes a build error when compiling ares__buf.c, due to not having SIZE_MAX declared. Tested by linking to the library as well as using adig and ahost. Fixes c-ares#622
Member
|
I wonder if it wouldn't be better to add this to src/lib/config_win32.h if openwatcom is in use? I assume you're using the static makefile.Watcom, in which case I'm pretty sure that config_win32.h is in use in that case. |
Contributor
Author
|
Yeah I'm using the static Makefile.Watcom, but I'm thinking putting it in src/lib/config_win32.h may be a better approach as well. I'll try that locally and then add another commit to the PR going that route |
Member
|
When you do commit, hopefully it triggers the workflow on the c-ares CI/CD system now to build using OpenWatcom |
This is an alternate method of fixing the build failure that doesn't involve a change to the Makefile and makes it so that it works regardless of the build system in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes building c-ares using the WATCOM compiler by adding -dHAVE_STDINT_H into the CFLAGS. On a configure or CMake based configuration, this would be added in by that process.
This fixes a build error when compiling ares__buf.c, due to not having SIZE_MAX declared.
Tested by linking to the library as well as using adig and ahost.
Fixes #622