Support attempts and timeout options from resolv.conf #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cannot realise reasons of failures on Darwin, I failed to reproduce it on my MacBook |
|
I think you may have found a bug in c-ares here as to why the macOS tests are failing. The environment reading should come after sysconfig reading here: https://github.com/c-ares/c-ares/blob/main/src/lib/ares_sysconfig.c#L998 as the environment is supposed to act as overrides. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c-ares parses only antique version of options for timeout and number of retries from resolv.conf (
retransandretryare missing in modern documentation https://man7.org/linux/man-pages/man5/resolv.conf.5.html).I add support of
attemptsandtimeoutoptions