Repository navigation
Replace configuration file parsers with memory-safe parser - #725
Merged
Merged
Conversation
bradh352
marked this pull request as draft
March 12, 2024 16:05
bradh352
marked this pull request as ready for review
March 16, 2024 14:51
bradh352
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite configuration parsers using new memory safe parsing functions. After CVE-2024-25629 its obvious that we need to prioritize again on getting all the hand written parsers with direct pointer manipulation replaced. They're just not safe and hard to audit. It was yet another example of 20+yr old code having a memory safety issue just now coming to light.
Though these parsers are definitely less efficient, they're written with memory safety in mind, and any performance difference is going to be meaningless for something that only happens once a while.
Fix By: Brad House (@bradh352)