Apple: reimplement DNS configuration reading#750
Merged
bradh352 merged 9 commits intoc-ares:mainfrom Apr 29, 2024
Merged
Conversation
This was referenced Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DNS configuration for apple is stored in the system configuration database. Apple does provide an emulated
/etc/resolv.confon MacOS (but not iOS), it cannot, however, represent the entirety of the DNS configuration. Alternatively, libresolv could be used to also retrieve some system configuration, but it too is not capable of retrieving the entirety of the DNS configuration.Attempts to use the preferred public API of
SCDynamicStoreCreate()and friends yielded incomplete DNS information. Instead, that leaves some apple "internal" symbols fromconfigdthat we need to access in order to get the entire configuration. We can see that we're not the only ones to do this as Google Chrome also does: https://chromium.googlesource.com/chromium/src/+/HEAD/net/dns/dns_config_watcher_mac.cc. These internal functions are what whatlibresolvandscutiluse to retrieve the dns configuration. Since these symbols are not publicly available, we will dynamically load the symbols fromlibSystemand import thednsinfo.hprivate header extracted from:https://opensource.apple.com/source/configd/configd-1109.140.1/dnsinfo/dnsinfo.h.