Revert PR #659

[VlkrS]

As described in #753 the change merged with #659 is ill-advised and leads to breakage in applications using c-ares on OpenBSD.

See also nodejs/node#52439

[bradh352]

Very interesting, I didn't evaluate SOCK_DNS when I accepted the original PR other than to check the relevant manpage that was linked in the PR which made no mention about its real use case or restrictions on its use.

It sounds like its an extension that is only allowed to be used by libc and not external 3rd parties? Odd.

Its unfortunate Theo replied in such a manner, however. As a maintainer looking in from the outside, I'm not sure how I could have caught this not being an OpenBSD user myself when the documentation it woefully incomplete. Also, the fact that no CI system seems to natively support OpenBSD means testing of this can't be automated.

[VlkrS]

Its unfortunate Theo replied in such a manner, however. As a maintainer looking in from the outside, I'm not sure how I could have caught this not being an OpenBSD user myself

Thanks for merging this so quickly.
I can't speak for anyone else, but as far as I am concerned, I see both your point and how this appeared to be a good idea to the person making the PR.

[catap]

Also, the fact that no CI system seems to natively support OpenBSD means testing of this can't be automated.

You may use https://github.com/vmactions/openbsd-vm to make CI for OpenBSD

[bradh352]

i actually found an alternative with cross-platform-actions and added minimal CI for OpenBSD and NetBSD

[catap]

i actually found an alternative with cross-platform-actions and added minimal CI for OpenBSD and NetBSD

I'm quite interesting in alternative solution. May you share the link? :)

[bradh352]

https://github.com/c-ares/c-ares/blob/main/.github/workflows/openbsd.yml https://github.com/c-ares/c-ares/blob/main/.github/workflows/netbsd.yml

…

On Wed, May 8, 2024, 5:21 PM Kirill A. Korinsky ***@***.***> wrote: i actually found an alternative with cross-platform-actions and added minimal CI for OpenBSD and NetBSD I'm quite interesting in alternative solution. May you share the link? :) — Reply to this email directly, view it on GitHub <#754 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEWRNXH4FP6UAYEHQFI2YELZBKJOZAVCNFSM6AAAAABHMJY3AOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGUYDEMZYGQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[catap]

On Wed, 08 May 2024 22:45:59 +0100, Brad House ***@***.***> wrote: https://github.com/c-ares/c-ares/blob/main/.github/workflows/openbsd.yml https://github.com/c-ares/c-ares/blob/main/.github/workflows/netbsd.yml

Thanks!

…

-- wbr, Kirill