Skip to content

Conversation

@bradh352
Copy link
Member

@bradh352 bradh352 commented May 19, 2024

Automatically detect configuration changes and reload. On systems which provide notification mechanisms, use those, otherwise fallback to polling. When a system configuration change is detected, it asynchronously applies the configuration in order to ensure it is a non-blocking operation for any queries which may still be being processed.

On Windows, however, changes aren't detected if a user manually sets/changes the DNS servers on an interface, it doesn't appear there is any mechanism capable of this. We are relying on NotifyIpInterfaceChange() for notifications.

Fixes Issue: #613

@bradh352 bradh352 marked this pull request as draft May 19, 2024 15:21
@bradh352
Copy link
Member Author

@bagder any comments/questions/concerns with this? I'm just enabling it always if EventThread is enabled.

@bradh352 bradh352 marked this pull request as ready for review May 22, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant