Basic support for SIG RR record (RFC 2931 / RFC 2535) #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current c-ares parser, as per PR #765 parsing was broken due to validation that didn't understand the
SIGrecord class. This PR adds basic, non validating, and incomplete support for theSIGrecord type. The additionalKEYandNXTwhich would be required for additional verification of the records is not implemented. It also does not store the raw unprocessed RR data that would be required for the validation.The primary purpose of this PR is to be able to recognize the record and handle some periphery aspects such as validation of the class associated with the RR and to not honor the TTL in the RR in the c-ares query cache since it will always be 0.
Fixes #765
Fix By: Brad House (@bradh352)