Skip to content

Tests: fix test cleanup race condition#803

Merged
bradh352 merged 3 commits intoc-ares:mainfrom
bradh352:wincancel
Jul 3, 2024
Merged

Tests: fix test cleanup race condition#803
bradh352 merged 3 commits intoc-ares:mainfrom
bradh352:wincancel

Conversation

@bradh352
Copy link
Member

@bradh352 bradh352 commented Jul 2, 2024

There was a thread passed data for processing that was cleaned up before thread exit, and it could cause a use-after-free in the test suite. This doesn't affect c-ares. This was found during trying to reproduce #798, but appears unrelated, don't use a helper thread as it isn't necessary.

Fix By: Brad House (@bradh352)

@bradh352 bradh352 changed the title add new test case for #798 Tests: fix test cleanup race condition Jul 3, 2024
@bradh352 bradh352 merged commit 614bdd8 into c-ares:main Jul 3, 2024
@bradh352 bradh352 deleted the wincancel branch July 3, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant