Propagate record duplication error code #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh352
added a commit
that referenced
this pull request
Jul 18, 2024
In c-ares 1.30.0 we started validating strings parsed are printable. This caused a regression in a pycares test case due to a wrong response code being returned as the error was being propagated from a different section of code that was assuming the only possible failure condition was out-of-memory. This PR adds a fix for this and also a test case to validate it. Ref: saghul/pycares#200 Fix By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Jul 18, 2024
In c-ares 1.30.0 we started validating strings parsed are printable. This caused a regression in a pycares test case due to a wrong response code being returned as the error was being propagated from a different section of code that was assuming the only possible failure condition was out-of-memory. This PR adds a fix for this and also a test case to validate it. Ref: saghul/pycares#200 Fix By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Jul 18, 2024
In c-ares 1.30.0 we started validating strings parsed are printable. This caused a regression in a pycares test case due to a wrong response code being returned as the error was being propagated from a different section of code that was assuming the only possible failure condition was out-of-memory. This PR adds a fix for this and also a test case to validate it. Ref: saghul/pycares#200 Fix By: Brad House (@bradh352)
Contributor
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In c-ares 1.30.0 we started validating strings parsed are printable. This caused a regression in a pycares test case due to a wrong response code being returned as the error was being propagated from a different section of code that was assuming the only possible failure condition was out-of-memory.
This PR adds a fix for this and also a test case to validate it.
Ref: saghul/pycares#200
Fix By: Brad House (@bradh352)