ares_destroy() race condition during shutdown due to missing lock#831
Merged
bradh352 merged 3 commits intoc-ares:mainfrom Jul 24, 2024
Merged
ares_destroy() race condition during shutdown due to missing lock#831bradh352 merged 3 commits intoc-ares:mainfrom
ares_destroy() race condition during shutdown due to missing lock#831bradh352 merged 3 commits intoc-ares:mainfrom
Conversation
bradh352
added a commit
that referenced
this pull request
Jul 24, 2024
…831) When using EventThreads, the config change cleanup code might manipulate the event update list if it uses file descriptors (such as on Linux). This was being done without a lock. Rework the event enqueuing to handle locking internally to prevent this and to simplify where it is used. This was found by chance during an ASAN CI run. Fix By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Jul 24, 2024
…831) When using EventThreads, the config change cleanup code might manipulate the event update list if it uses file descriptors (such as on Linux). This was being done without a lock. Rework the event enqueuing to handle locking internally to prevent this and to simplify where it is used. This was found by chance during an ASAN CI run. Fix By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Jul 24, 2024
…831) When using EventThreads, the config change cleanup code might manipulate the event update list if it uses file descriptors (such as on Linux). This was being done without a lock. Rework the event enqueuing to handle locking internally to prevent this and to simplify where it is used. This was found by chance during an ASAN CI run. Fix By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Jul 24, 2024
…831) When using EventThreads, the config change cleanup code might manipulate the event update list if it uses file descriptors (such as on Linux). This was being done without a lock. Rework the event enqueuing to handle locking internally to prevent this and to simplify where it is used. This was found by chance during an ASAN CI run. Fix By: Brad House (@bradh352)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using EventThreads, the config change cleanup code might manipulate the event update list if it uses file descriptors (such as on Linux). This was being done without a lock. Rework the event enqueuing to handle locking internally to prevent this and to simplify where it is used. This was found by chance during an ASAN CI run.
Fix By: Brad House (@bradh352)