Data Structure: Dynamic Array - #841
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a new data structure for a basic growable indexable array, supporting the features you'd normally expect such as insert (at, last, first), remove (at, last, first), and get (at, last, first). Internally all data is stored in an appropriately sized array that can directly be returned to the caller as a C array of the data type provided. The array grows by powers of two, and has optimizations for head and tail removals.
Array modifications can be risky (e.g. wrong reallocation sizes, mis-sized memory moves, out-of-bounds access), so it makes sense to have standardized code that is well tested.
The arrays used by the dns record parser / writer have been converted to the new array data structure as have a few other instances.
Authored-By: Brad House (@bradh352)