Fix Sysconfig ndots default value and add test case #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh352
added a commit
that referenced
this pull request
Aug 22, 2024
As per #852 searching is failing, partially it is due to the ndots value not defaulting to a proper value on linux, and partially due to systemd-resolved returning the wrong error codes. This PR fixes the first issue and adds containerized test cases to validate the behavior and prevent issues in the future. Reported-By: Hans-Christian Egtvedt (@egtvedt) and Mikael Lindemann(@mikaellindemann) Authored-By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Aug 22, 2024
As per #852 searching is failing, partially it is due to the ndots value not defaulting to a proper value on linux, and partially due to systemd-resolved returning the wrong error codes. This PR fixes the first issue and adds containerized test cases to validate the behavior and prevent issues in the future. Reported-By: Hans-Christian Egtvedt (@egtvedt) and Mikael Lindemann(@mikaellindemann) Authored-By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Aug 22, 2024
As per #852 searching is failing, partially it is due to the ndots value not defaulting to a proper value on linux, and partially due to systemd-resolved returning the wrong error codes. This PR fixes the first issue and adds containerized test cases to validate the behavior and prevent issues in the future. Reported-By: Hans-Christian Egtvedt (@egtvedt) and Mikael Lindemann(@mikaellindemann) Authored-By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Aug 22, 2024
As per #852 searching is failing, partially it is due to the ndots value not defaulting to a proper value on linux, and partially due to systemd-resolved returning the wrong error codes. This PR fixes the first issue and adds containerized test cases to validate the behavior and prevent issues in the future. Reported-By: Hans-Christian Egtvedt (@egtvedt) and Mikael Lindemann(@mikaellindemann) Authored-By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Aug 22, 2024
As per #852 searching is failing, partially it is due to the ndots value not defaulting to a proper value on linux, and partially due to systemd-resolved returning the wrong error codes. This PR fixes the first issue and adds containerized test cases to validate the behavior and prevent issues in the future. Reported-By: Hans-Christian Egtvedt (@egtvedt) and Mikael Lindemann(@mikaellindemann) Authored-By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Aug 22, 2024
As per #852 searching is failing, partially it is due to the ndots value not defaulting to a proper value on linux, and partially due to systemd-resolved returning the wrong error codes. This PR fixes the first issue and adds containerized test cases to validate the behavior and prevent issues in the future. Reported-By: Hans-Christian Egtvedt (@egtvedt) and Mikael Lindemann(@mikaellindemann) Authored-By: Brad House (@bradh352)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #852 searching is failing, partially it is due to the ndots value not defaulting to a proper value on linux, and partially due to systemd-resolved returning the wrong error codes.
This PR fixes the first issue and adds containerized test cases to validate the behavior and prevent issues in the future.
Reported-By: Hans-Christian Egtvedt (@egtvedt) and Mikael Lindemann(@mikaellindemann)
Authored-By: Brad House (@bradh352)