systemd-resolved handle ESERVFAIL/EREFUSED on single label names#863
Merged
bradh352 merged 2 commits intoc-ares:mainfrom Aug 23, 2024
Merged
systemd-resolved handle ESERVFAIL/EREFUSED on single label names#863bradh352 merged 2 commits intoc-ares:mainfrom
bradh352 merged 2 commits intoc-ares:mainfrom
Conversation
bradh352
added a commit
that referenced
this pull request
Aug 23, 2024
systemd-resolved will return `ESERVFAIL` or `EREFUSED` by default on single label domain names. See systemd/systemd#34101 They've basically labeled this as a non-issue even though it appears to be in violation of the RFCs for downstream systems being able to support negative caching. I haven't tested with the suggested `ResolveUnicastSingleLabel=yes`, but that's off by default so its unlikely people even knows this exists. Since systemd is very prevalent these days, we really don't have much of a choice but to work around their design decisions. This PR implements this support, but *only* on single label names as it likely isn't valid otherwise. It also adds test cases to confirm this behavior. Fixes #852 Authored-By: Brad House (@bradh352)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
systemd-resolved will return
ESERVFAILorEREFUSEDby default on single label domain names. See systemd/systemd#34101They've basically labeled this as a non-issue even though it appears to be in violation of the RFCs for downstream systems being able to support negative caching. I haven't tested with the suggested
ResolveUnicastSingleLabel=yes, but that's off by default so its unlikely people even knows this exists.Since systemd is very prevalent these days, we really don't have much of a choice but to work around their design decisions. This PR implements this support, but only on single label names as it likely isn't valid otherwise. It also adds test cases to confirm this behavior.
Fixes #852
Authored-By: Brad House (@bradh352)