Remove ares__ prefix, just use ares_#872
Merged
bradh352 merged 2 commits intoc-ares:mainfrom Sep 4, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point in time, internal non-public functions were prefixed with
ares__where as functions that may become public were prefixed with justares_. This was never very consistent. Organizing the code better typically provides more benefit in this way, which we've made great progress on.All non-static symbols must contain the
ares_prefix, and that should be more than sufficient in preventing any sort of issues.Authored-By: Brad House (@bradh352)