CMake: strip -l prefix on CMAKE_THREAD_LIBS_INIT#884
Merged
bradh352 merged 1 commit intoc-ares:mainfrom Sep 16, 2024
Merged
Conversation
bradh352
added a commit
that referenced
this pull request
Sep 16, 2024
As per Issue #883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes #883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Sep 16, 2024
As per Issue #883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes #883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Sep 16, 2024
As per Issue #883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes #883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Sep 16, 2024
As per Issue #883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes #883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Sep 16, 2024
As per Issue #883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes #883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Sep 16, 2024
As per Issue #883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes #883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Sep 16, 2024
As per Issue #883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes #883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Sep 16, 2024
As per Issue #883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes #883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
As per Issue c-ares#883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes c-ares#883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
As per Issue c-ares#883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes c-ares#883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
As per Issue c-ares#883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes c-ares#883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
As per Issue c-ares#883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes c-ares#883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
As per Issue c-ares#883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes c-ares#883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
As per Issue c-ares#883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes c-ares#883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
As per Issue c-ares#883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes c-ares#883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
As per Issue c-ares#883, an incorrect `libcares.pc` can be generated when `CMAKE_THREAD_LIBS_INIT` contains a value like `-lpthread` because it gets added to `libcares.pc` with another `-l` prefix. We can't control the behavior of `CMAKE_THREAD_LIBS_INIT` since its set by `FIND_PACKAGE (Threads)`. Lets strip the `-l` prefix from the library before adding it to `CARES_DEPENDENT_LIBS` which is used in the generation of `libcares.pc`. Fixes c-ares#883 Reported-By: 前进，前进，进 (@leleliu008) Fix By: Brad House (@bradh352)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per Issue #883, an incorrect
libcares.pccan be generated whenCMAKE_THREAD_LIBS_INITcontains a value like-lpthreadbecause it gets added tolibcares.pcwith another-lprefix. We can't control the behavior ofCMAKE_THREAD_LIBS_INITsince its set byFIND_PACKAGE (Threads).Lets strip the
-lprefix from the library before adding it toCARES_DEPENDENT_LIBSwhich is used in the generation oflibcares.pc.Fixes #883
Reported-By: 前进，前进，进 (@leleliu008)
Fix By: Brad House (@bradh352)