CMake: unix-like systems don't need a static library suffix - #933
Merged
Conversation
bradh352
added a commit
that referenced
this pull request
Dec 11, 2024
On Windows, the output name should have a static suffix since otherwise we would have conflicting output names (libcares.lib) for the link library. However on Unix-like systems, we typically have something like libcares.so for shared libraries and libcares.a for static libraries, so these don't conflict. This behavior better emulates what happens with autotools builds. This fixes issues with package config and trying to static link when you have c-ares built as both dynamic and static. Discussion from #925 Signed-off-by: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
On Windows, the output name should have a static suffix since otherwise we would have conflicting output names (libcares.lib) for the link library. However on Unix-like systems, we typically have something like libcares.so for shared libraries and libcares.a for static libraries, so these don't conflict. This behavior better emulates what happens with autotools builds. This fixes issues with package config and trying to static link when you have c-ares built as both dynamic and static. Discussion from c-ares#925 Signed-off-by: Brad House (@bradh352)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the output name should have a static suffix since otherwise we would have conflicting output names (libcares.lib) for the link library. However on Unix-like systems, we typically have something like libcares.so for shared libraries and libcares.a for static libraries, so these don't conflict. This behavior better emulates what happens with autotools builds.
This fixes issues with package config and trying to static link when you have c-ares built as both dynamic and static.
Discussion from #925
Signed-off-by: Brad House (@bradh352)