QNX: enhance config reading#938
Merged
Merged
Conversation
Member
Author
|
@bagder do you think this PR will finish off your needs for QNX modifications? |
…le builds on pull requests
Member
|
Thanks! It certainly looks like this at least fixes the build issues. I'm not completely educated about the purposes of all the QNX specific commits, but if there are additional details that "need" to be fixed we can work on them in follow-up PRs. |
Member
Author
|
I just ran through the test cases on a QNX vm i spun up, the only thing that failed was service name lookup due to getservbyname() not returning resuls, likely due to lack of /etc/services ... I think its a seldom-used feature, not sure the proper workaround. |
Member
Author
|
I found one bug in reading confstr, I was able to use setconf on the command line to get a string to parse. anyhow, I think this stuff is looking good now. |
bradh352
added a commit
that referenced
this pull request
Dec 14, 2024
QNX prefers config read from confstr(_CS_RESOLVE, ...) and confstr(_CS_DOMAIN, ...) rather than those read from /etc/resolv.conf and friends which are only used as fallbacks. Its documented that confstr() reads from /etc/net.cfg, but that file format is NOT documented so we can't read directly from there ... however, we can monitor that file for changes to know when the system config has been updated. This has been validated to successfully build, but has not yet had the tests run on an actual QNX platform. Build results here: https://github.com/bradh352/c-ares/actions/runs/12324751945/job/34402863134 Signed-off-by: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
QNX prefers config read from confstr(_CS_RESOLVE, ...) and confstr(_CS_DOMAIN, ...) rather than those read from /etc/resolv.conf and friends which are only used as fallbacks. Its documented that confstr() reads from /etc/net.cfg, but that file format is NOT documented so we can't read directly from there ... however, we can monitor that file for changes to know when the system config has been updated. This has been validated to successfully build, but has not yet had the tests run on an actual QNX platform. Build results here: https://github.com/bradh352/c-ares/actions/runs/12324751945/job/34402863134 Signed-off-by: Brad House (@bradh352)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QNX prefers config read from confstr(_CS_RESOLVE, ...) and confstr(_CS_DOMAIN, ...) rather than those read from /etc/resolv.conf and friends which are only used as fallbacks. Its documented that confstr() reads from /etc/net.cfg, but that file format is NOT documented so we can't read directly from there ... however, we can monitor that file for changes to know when the system config has been updated.
This has been validated to successfully build, but has not yet had the tests run on an actual QNX platform. Build results here:
https://github.com/bradh352/c-ares/actions/runs/12324751945/job/34402863134
Signed-off-by: Brad House (@bradh352)