Port: restore Windows XP minimal support#958
Merged
Merged
Conversation
Member
Author
|
needed to create this as a PR to spawn off AppVeyor tests that actually test building of Windows XP support |
…or issues (c-ares#957) Containerized tests now need to be run with sudo to gain access to chroot(). Also, `gcov` in ubuntu 24.04 is broken with googletest so revert back to 22.04 for coverage. Finally, codespell is updated in 24.04 to detect more issues and there were some typos that needed to be fixed. Signed-off-by: Brad House (@bradh352)
bradh352
changed the title
bradh352
added a commit
that referenced
this pull request
Jan 9, 2025
Windows XP support was removed in 2021, but we've had a recent request for basic Windows XP support. It looks like the needed changes are very minimal these days, the only real requirement is to build without threading support, everything else can be conditionally bypassed. This changeset mostly just disables building the event subsystem if threading is disabled then makes a couple minor build system changes to allow overriding of the `_WIN32_WINNT` macro. Fixes #956 --------- Signed-off-by: Brad House (@bradh352)
bradh352
added a commit
that referenced
this pull request
Jan 14, 2025
continuation of PR #958 This brings forward Threading and Event Subsystem support by doing a few additional ifdefs and falling back for functions that were not part of Windows XP. I don't know how likely this is to work on a real XP system, but at least targeting XP while compiling and running through test cases on the CI/CD system works as expected (CI/CD runs a recent Windows Server version) . Signed-off-by: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
Windows XP support was removed in 2021, but we've had a recent request for basic Windows XP support. It looks like the needed changes are very minimal these days, the only real requirement is to build without threading support, everything else can be conditionally bypassed. This changeset mostly just disables building the event subsystem if threading is disabled then makes a couple minor build system changes to allow overriding of the `_WIN32_WINNT` macro. Fixes c-ares#956 --------- Signed-off-by: Brad House (@bradh352)
michael-dev
pushed a commit
to HamelinPorts/android_external_c-ares
that referenced
this pull request
Apr 25, 2026
…res#960) continuation of PR c-ares#958 This brings forward Threading and Event Subsystem support by doing a few additional ifdefs and falling back for functions that were not part of Windows XP. I don't know how likely this is to work on a real XP system, but at least targeting XP while compiling and running through test cases on the CI/CD system works as expected (CI/CD runs a recent Windows Server version) . Signed-off-by: Brad House (@bradh352)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows XP support was removed in 2021, but we've had a recent request for basic Windows XP support. It looks like the needed changes are very minimal these days, the only real requirement is to build without threading support, everything else can be conditionally bypassed.
This changeset mostly just disables building the event subsystem if threading is disabled then makes a couple minor build system changes to allow overriding of the
_WIN32_WINNTmacro.Fixes #956