Skip to content

Conversation

@ELLIOTTCABLE
Copy link
Contributor

As requested!

Couple notes: 1. Formatting in the README felt a little strange to me, but I opted to maintain the existing style rather than try to unilaterally ‘fix’ it. Hopefully it works out to your standards! 2. I tend towards very granular commits, again, hope you don't mind the volume of individual changes (ignore anything with the - tag), and 3. added myself as a contributor. Hope that isn't presumptuous. [=

@ELLIOTTCABLE
Copy link
Contributor Author

Oh, and GitHub is weird about pull-requests. Feel free to manually pull the commits from my fork; and don't forget the release-tag, unless you want me to make some changes and rebase them in.

I'll hit publish on the npm release as soon as you review and fast-forward the upstream! <3

@c-cube
Copy link
Owner

c-cube commented May 1, 2019

Looks nice, just a question: why 0.5.3 and not 0.5.2?

@ELLIOTTCABLE ELLIOTTCABLE changed the title BuckleScript support, and bump to 0.5.3 BuckleScript support, and bump to 0.5.2 May 4, 2019
@ELLIOTTCABLE
Copy link
Contributor Author

Because I'm a fool 🤣

Fixed, rewritten, and pushed!

@c-cube c-cube merged commit 999d4da into c-cube:master May 4, 2019
@ELLIOTTCABLE
Copy link
Contributor Author

ELLIOTTCABLE commented May 10, 2019

You might want to update the homepage in the package.json to match — since cedeela.fr doesn't resolve anymore.

Anyway: out on npm! https://www.npmjs.com/package/bs-gen

Let me know if you ever get into JS-land stuff and create an npm account; I'll make sure you're added as a contributor so you can publish new versions. Until then, also feel free to cc/ me if you bump the version, and I'm happy to pull your changes and publish them! (=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants