-
Notifications
You must be signed in to change notification settings - Fork 10
BuckleScript support, and bump to 0.5.2 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I need to speak to upstream before I actually bump the version. I really don't want to decouple unless I have to.
|
Oh, and GitHub is weird about pull-requests. Feel free to manually pull the commits from my fork; and don't forget the release-tag, unless you want me to make some changes and rebase them in. I'll hit publish on the npm release as soon as you review and fast-forward the upstream! |
|
Looks nice, just a question: why 0.5.3 and not 0.5.2? |
|
Because I'm a fool 🤣 Fixed, rewritten, and pushed! |
|
You might want to update the homepage in the Anyway: out on npm! https://www.npmjs.com/package/bs-gen Let me know if you ever get into JS-land stuff and create an npm account; I'll make sure you're added as a contributor so you can publish new versions. Until then, also feel free to cc/ me if you bump the version, and I'm happy to pull your changes and publish them! (= |
As requested!
Couple notes: 1. Formatting in the README felt a little strange to me, but I opted to maintain the existing style rather than try to unilaterally ‘fix’ it. Hopefully it works out to your standards! 2. I tend towards very granular commits, again, hope you don't mind the volume of individual changes (ignore anything with the
-tag), and 3. added myself as a contributor. Hope that isn't presumptuous.[=