Increase favicon resolution #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a convenient favicon verifier. It has been a few years now since the last time I did favicons. The rules have changed a bit. For the obsessive, there are still a few of the oldschool ones: https://github.com/audreyr/favicon-cheat-sheet But it doesn't seem like those are necessary anymore. So looks good to me! The Safari one could use some work...I didn't realize they got pinned tabs from their own new exclusive svg favicon. |
brandenbyers
approved these changes
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branden was a bit too eager to merge my last pr, so this one adds in the changes I made after his comments about resolution.