Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Krita plugin #102

Closed
wants to merge 4 commits into from
Closed

Add Krita plugin #102

wants to merge 4 commits into from

Conversation

amyspark
Copy link
Contributor

Hi @c-koi and @dtschump,

This PR is to upstream the changes I made to plugin-ify GMic-Qt in Krita. This work was done in !581.

It's mostly a port of the existing Krita host, but with the following changes:

  • it resides on the same memory space as the host app, so it directly shares pointers to a structure that mimics the old messages
  • adds KDE's ECM as a dependency to install the plugin to Krita's directory hierarchy
  • links against an exported module of Krita master named "kis_qmic_interface", which is a 1-1 implementation of the old messages as exported functions
  • implements all previously unsupported input modes, as they've been made available on Krita master

@c-koi
Copy link
Owner

c-koi commented Jan 29, 2021

@amyspark @cgilles

We would like to thank you again for your contributions to make the G'MIC-Qt plugin work on Digikam and Krita. Having G'MIC-Qt working on different host applications is very valuable to us and we really appreciate the work you've accomplished for this purpose. The improvements of the new plugin version for Krita look good.

Recently, we have thought long and hard about how we can incorporate contributions in the upstream repository gmic-qt. We have written a detailed "Contributing - New host HOWTO" guidelines, and from now on, we will only accept PRs that comply with these rules.

For you, this means we will not incorporate your code or PR (in their current forms) in the gmic-qt repository. We have indeed noticed that this part of the code (for DigiKam) and this one (for the new Krita plugin) are duplicates/variations of the launchPlugin() functions which could break the compatibility with future versions of the plugin, not to mention the few drawbacks which are listed in the guidelines.

In any case, we will be happy to share links to your alternative implementations when we become aware of their locations, here and on the official G'MIC website.

Thanks again for all your efforts.

Sébastien and David.

@amyspark amyspark closed this Jan 29, 2021
@amyspark amyspark deleted the amyspark/krita-plugin branch January 29, 2021 21:18
@hallarempt
Copy link
Contributor

It might be better to completely remove the krita host then because it will not work with Krita going forward.

@dtschump
Copy link
Collaborator

Shouldn't we keep it alive for older versions of Krita ?

@hallarempt
Copy link
Contributor

Not in the repository, the last release is good enough for that.

@cgilles
Copy link
Contributor

cgilles commented Jan 30, 2021

Please remove digiKam plugin too...

@dtschump
Copy link
Collaborator

dtschump commented Feb 3, 2021

@boudewijnrempt @amyspark : We have decided to keep the 'old' version of the plug-in for Krita alive, until you release an official build of Krita that contains your new embedded version of the G'MIC-Qt plug-in.
This way, people using older versions of Krita will be able to update to newer versions of G'MIC.
We'll remove it when the new Krita + G'MIC-Qt included will be released.

@hallarempt
Copy link
Contributor

We have long since released a version of krita with our fork of the gmic-qt plugin.

@c-koi
Copy link
Owner

c-koi commented Nov 21, 2022

@hallarempt @amyspark Krita specific code has been removed (65a0e94)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants