This repository has been archived by the owner on Apr 10, 2019. It is now read-only.
Add missing typedef for CRef #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of `libbus1` fails to build from source with `c-sundry` commit 8deaceb because of a missing type definition for `CRef`. Since `c-ref.h` provides `CRefFn`, it seems logical to provide `CRef` there as well.
|
This typedef was deleted on purpose. There is no need for it. On the contrary, it adds a dependency where none is needed. libbus1 is an outdated library that is no longer needed with up-to-date bus1.ko. Hence, I'd just leave it as is. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The current version of
libbus1fails to build from source withc-sundrycommit 8deaceb because of a missing type definition for
CRef.Since
c-ref.hprovidesCRefFn, it seems logical to provideCRefthere as well.