Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when running with -s|--shell #87

Merged
merged 4 commits into from Aug 8, 2020
Merged

Fix crash when running with -s|--shell #87

merged 4 commits into from Aug 8, 2020

Conversation

c-w
Copy link
Owner

@c-w c-w commented Aug 8, 2020

When running ghp-import with -s or --shell, the first subprocess call fails as the git sub-command to run isn't recognized. This seems to be caused by the code not respecting the documentation for subprocess.Popen which mentions that when shell=True is passed as an argument, the command should be passed as a string instead of an array.

@c-w c-w linked an issue Aug 8, 2020 that may be closed by this pull request
@c-w c-w merged commit 777bcb4 into master Aug 8, 2020
@c-w c-w deleted the fix-shell branch Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execute on shell to recoginze
1 participant