Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid bare except #93

Merged
merged 1 commit into from Oct 29, 2017

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Owner

commented Oct 29, 2017

Fixes #92

@c-w c-w requested a review from hugovk Oct 29, 2017

@hugovk

This comment has been minimized.

Copy link
Collaborator

commented Oct 29, 2017

I guess the general idea of the warning is to catch more specific exceptions, but it can be hard to know what the intention was with old code so this is fine. In the future let's be more specific with new ones.

@hugovk hugovk merged commit 2c81e5a into master Oct 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hugovk hugovk deleted the fix-flake8 branch Oct 29, 2017

@MasterOdin

This comment has been minimized.

Copy link
Collaborator

commented Oct 29, 2017

For the ones that catch Exception and then just immediately reraise, is there really even a point to having them?

@hugovk

This comment has been minimized.

Copy link
Collaborator

commented Oct 29, 2017

They don't do much, do they? Let's remove them!

@hugovk

This comment has been minimized.

Copy link
Collaborator

commented Nov 4, 2017

See PR #94.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.