Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook for integrating with react-quill #10

Merged
merged 2 commits into from Jun 25, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Owner

commented Jun 25, 2019

This change adds a new top-level function window.mathquill4quill which acts as a factory method for the enableMathQuillFormulaAuthoring call. Decoupling the enableMathQuillFormulaAuthoring call from the Quill instance enables integrating the mathquill4quill library with other projects that are built on-top of Quill such as react-quill mentioned in #9.

@c-w

This comment has been minimized.

Copy link
Owner Author

commented Jun 25, 2019

@boomanaiden154 given that you've contributed a lot to this project recently, would you mind taking a look at this pull request and let me know your thoughts? Thanks in advance!

@c-w c-w force-pushed the react-quill-integration branch from 92f376a to 6f4fddd Jun 25, 2019

@c-w c-w force-pushed the react-quill-integration branch from 6f4fddd to 05d669c Jun 25, 2019

@boomanaiden154
Copy link
Collaborator

left a comment

It looks good. The preservation of the functionality outside react-quill would be what I am most concerned about, and this is preserved with a minor breaking change upon update to the latest version(just need to slightly refactor the code enabling mathquill4quill). I don't have much experience with react, but it looks good.

@c-w

This comment has been minimized.

Copy link
Owner Author

commented Jun 25, 2019

Thanks for taking a look @boomanaiden154. Note that the change is fully backwards compatible and I've verified that the previous method of initialization via quill.enableMathQuillFormulaAuthoring(options) continues to work. The only change is that now we expose a top-level function on window but this shouldn't impact existing applications (unless mathquill4quill is already defined as a global which seems unlikely).

@c-w c-w merged commit f4adf00 into master Jun 25, 2019

1 check passed

c-w.mathquill4quill Build #20190625.3 succeeded
Details

@c-w c-w deleted the react-quill-integration branch Jun 25, 2019

@boomanaiden154

This comment has been minimized.

Copy link
Collaborator

commented Jun 25, 2019

@c-w guess I didn't see the part at the end that exposed the function with quill.prototype. Everything looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.