Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minified asset to npm package #26

Merged
merged 1 commit into from Jan 8, 2020
Merged

Conversation

@c-w
Copy link
Owner

c-w commented Dec 28, 2019

The package published to NPM currently contains all the files in the repository which includes a bunch of unnecessary files (e.g. the code for the demo page).

This pull request makes the listing of files published to NPM explicit to include only:

  • mathquill4quill.js: the core library written in ES6.
  • build/mathquill4quill.min.js: a babelified and minified version of the file for older browsers.
@c-w c-w requested a review from boomanaiden154 Dec 28, 2019
@boomanaiden154

This comment has been minimized.

Copy link
Collaborator

boomanaiden154 commented Jan 8, 2020

This looks good. Everything is still linked to the Github repo from NPM, and it doesn't make sense to randomly duplicate files.

@boomanaiden154 boomanaiden154 merged commit 8d58c3a into master Jan 8, 2020
1 check passed
1 check passed
c-w.mathquill4quill Build #20191228.8 succeeded
Details
Copy link
Collaborator

boomanaiden154 left a comment

Looks good. We don't need to be cluttering up projects when people install it from NPM. Might help install time slightly.

@c-w c-w deleted the npm-publish-minified branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.