Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd minified asset to npm package #26
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
This looks good. Everything is still linked to the Github repo from NPM, and it doesn't make sense to randomly duplicate files. |
|
Looks good. We don't need to be cluttering up projects when people install it from NPM. Might help install time slightly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
c-w commentedDec 28, 2019
The package published to NPM currently contains all the files in the repository which includes a bunch of unnecessary files (e.g. the code for the demo page).
This pull request makes the listing of files published to NPM explicit to include only:
mathquill4quill.js: the core library written in ES6.build/mathquill4quill.min.js: a babelified and minified version of the file for older browsers.