Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options.autofocus=false being discarded #30

merged 1 commit into from Jan 21, 2020


Copy link

@c-w c-w commented Jan 17, 2020

Currently the autofocus option can't be disabled since options.autofocus || true evaluates to true even if the option is explicitly set to false. Using the default value only if the provided value is null fixes the problem.

@c-w c-w requested a review from boomanaiden154 Jan 17, 2020
@c-w c-w merged commit e89ee8b into master Jan 21, 2020
1 check passed
@c-w c-w deleted the bugfix/autofocus-value-ignored branch Jan 21, 2020
@c-w c-w removed the request for review from boomanaiden154 Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant