Make styles overridable #36
Conversation
|
@c-w - I have not reviewed this locally, but it looks great to me code wise! It might be worth documenting this new functionality in the README, that way you don't get other folks asking the same question I did 😅 |
|
I also wanted to mention that if it's at all possible, I think for accessibility and overriding styles, it would be awesome if mathquill4quill could use a stylesheet. The reason I am even looking into this is because inline styles can make it difficult for users to customize our site if they have vision impairments, like this accessibility article describes. |
c-w
force-pushed
the
customizable-styling
branch
from
d939675
to
4604404
Compare
|
Thanks for the input @vkoves. I moved the styles to an external stylesheet with the latest update on this pull request. Let me know if you have any further improvement suggestions; if not, I'll merge this and create a new release which will be a major version bump since introducing the stylesheet is a breaking change. |
* Added support to display and save formula history. Also fixed generic quill positioning issue * Fix Lint errors * Ran prettier on file * Addressed chromedriver issue * Make styles overridable (#36) * Make styles overridable * Move styles to CSS file * Add CSS linter * Update chromedriver to version used in CI * Release version 2.0.0 * Remove intermediate babel output from build (#41) * Enable passing through mathquill configuration (#38) * Added in mathquill config option * Added in support for user-defined handlers * Fixed code formatting and added rule to eslint for object spreading * Changed chromedriver version * Release version 2.0.1 * Ensure non-minified JS is released as artifact (#42) * Added support to display and save formula history. Also fixed generic quill positioning issue * Fix Lint errors * Ran prettier on file * Addressed chromedriver issue * Update ReadME for history list. Co-authored-by: Clemens Wolff <clemens@justamouse.com> Co-authored-by: boomanaiden154 <39388941+boomanaiden154@users.noreply.github.com>
Resolves #35