Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make styles overridable #36

Merged
merged 4 commits into from Feb 27, 2020
Merged

Make styles overridable #36

merged 4 commits into from Feb 27, 2020

Conversation

c-w
Copy link
Owner

@c-w c-w commented Feb 14, 2020

Resolves #35

@vkoves
Copy link

@vkoves vkoves commented Feb 16, 2020

@c-w - I have not reviewed this locally, but it looks great to me code wise! It might be worth documenting this new functionality in the README, that way you don't get other folks asking the same question I did 😅

@vkoves
Copy link

@vkoves vkoves commented Feb 16, 2020

I also wanted to mention that if it's at all possible, I think for accessibility and overriding styles, it would be awesome if mathquill4quill could use a stylesheet. The reason I am even looking into this is because inline styles can make it difficult for users to customize our site if they have vision impairments, like this accessibility article describes.

@c-w c-w force-pushed the customizable-styling branch from d939675 to 4604404 Compare Feb 26, 2020
@c-w
Copy link
Owner Author

@c-w c-w commented Feb 26, 2020

Thanks for the input @vkoves. I moved the styles to an external stylesheet with the latest update on this pull request. Let me know if you have any further improvement suggestions; if not, I'll merge this and create a new release which will be a major version bump since introducing the stylesheet is a breaking change.

vkoves
vkoves approved these changes Feb 26, 2020
Copy link

@vkoves vkoves left a comment

This looks great to me, thank you so much for addressing this!

@c-w c-w merged commit f215cbb into master Feb 27, 2020
1 check passed
@c-w c-w deleted the customizable-styling branch Feb 27, 2020
boomanaiden154 added a commit that referenced this issue Feb 29, 2020
* Added support to display and save formula history. Also fixed generic quill positioning issue

* Fix Lint errors

* Ran prettier on file

* Addressed chromedriver issue

* Make styles overridable (#36)

* Make styles overridable

* Move styles to CSS file

* Add CSS linter

* Update chromedriver to version used in CI

* Release version 2.0.0

* Remove intermediate babel output from build (#41)

* Enable passing through mathquill configuration (#38)

* Added in mathquill config option

* Added in support for user-defined handlers

* Fixed code formatting and added rule to eslint for object spreading

* Changed chromedriver version

* Release version 2.0.1

* Ensure non-minified JS is released as artifact (#42)

* Added support to display and save formula history. Also fixed generic quill positioning issue

* Fix Lint errors

* Ran prettier on file

* Addressed chromedriver issue

* Update ReadME for history list.

Co-authored-by: Clemens Wolff <clemens@justamouse.com>
Co-authored-by: boomanaiden154 <39388941+boomanaiden154@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants