New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to zoom types (scroll and drag) with option to disable default zoom behavior #1500

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
10 participants
@mistic
Copy link
Contributor

mistic commented Dec 10, 2015

New api for zoom:

zoom: {
    enabled: true,
    type: 'drag', // can be [drag, scroll]
    disableDefaultBehavior: false // if yes chart don't zoom but user will have x domain of the zoom box. This is more util for drag zoom type.
}
@aendrew

This comment has been minimized.

Copy link
Member

aendrew commented Dec 18, 2015

Hi @misticini!

Looks good to me! 👍 Thank you for adding documentation, that's always massively appreciated! 💯

I just tested it and it behaves wonderfully. Very nicely done!

Please do the following —

  1. Remove all the compiled assets — c3.js, c3.min.js, c3.css — from your commits. These get created during releases only.
  2. Squash all your commits.

Thanks!

@mistic mistic force-pushed the mistic:master branch 4 times, most recently from 60b7656 to ff94e04 Dec 18, 2015

@mistic

This comment has been minimized.

Copy link
Contributor Author

mistic commented Dec 18, 2015

Hi @aendrew

  1. Done
  2. Done

Thank u for your feedback 👍

@mistic mistic force-pushed the mistic:master branch 3 times, most recently from a8ef1a0 to 4fef919 Dec 18, 2015

@aendrew

This comment has been minimized.

Copy link
Member

aendrew commented Dec 18, 2015

@misticini Brilliantly done! RTBC, merge away @masayuki0812! 😄 :shipit: 💯 💥

@mistic mistic force-pushed the mistic:master branch 3 times, most recently from 9291516 to a521c90 Dec 28, 2015

@mistic mistic force-pushed the mistic:master branch from a521c90 to 1c3d5bb Jan 13, 2016

@aendrew

This comment has been minimized.

Copy link
Member

aendrew commented May 2, 2016

@misticini Quick question — any idea why the commit's author is @tiagoferreira-mindera? Is that just a new account or what?

@aendrew aendrew added the RTBC label May 2, 2016

@mistic

This comment has been minimized.

Copy link
Contributor Author

mistic commented Jun 25, 2016

Hi @aendrew

The commit's author is only my company's github account :)

Added support to zoom types (scroll and drag) with option to disable …
…default zoom behavior.

Added uncorrect removed files.

Fixed build files permissions.

Fixed visibility property spelling.

Fixed bug on returned zoom domain in 'onzoomend' event.

Prevent a drag from a single click.

removed fix for false click.

Fixed bug in update zoom when zoom type is drag.

@mistic mistic force-pushed the mistic:master branch from 1c3d5bb to bfad261 Jul 20, 2016

@mistic

This comment has been minimized.

Copy link
Contributor Author

mistic commented Jul 20, 2016

I've changed the commits author :)

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 20, 2016

Current coverage is 63.55%

Merging #1500 into master will decrease coverage by 0.49%

@@             master      #1500   diff @@
==========================================
  Files             1          1          
  Lines          4400       4439    +39   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2818       2821     +3   
- Misses         1582       1618    +36   
  Partials          0          0          

Powered by Codecov. Last updated by 223404a...5607266

@Irrelon

This comment has been minimized.

Copy link

Irrelon commented Apr 10, 2017

Is there an intention to merge this in at some point?

@mistic

This comment has been minimized.

Copy link
Contributor Author

mistic commented May 19, 2017

@Irrelon I don't really know because it's already pass more than an year :(

Hey guys what do u think? ( @aendrew @masayuki0812 ) ?

@kt3k

kt3k approved these changes Jun 13, 2017

@a244096658

This comment has been minimized.

Copy link

a244096658 commented Jun 22, 2017

Hi,

When will this new feature be added into a new release? Thanks!

@kt3k kt3k added this to the 1.0 milestone Aug 19, 2017

@kt3k kt3k modified the milestones: 0.5, 0.6 Mar 25, 2018

@kt3k kt3k removed this from the 0.6 milestone Apr 12, 2018

@kt3k kt3k added this to the 0.7 milestone Apr 12, 2018

@binakot

This comment has been minimized.

Copy link

binakot commented Apr 16, 2018

Please, add this PR to the next release :shipit:

@kt3k Is there any reason to not adding this functionality for 3 years?

@tovinayv

This comment has been minimized.

Copy link

tovinayv commented Apr 25, 2018

Even i'm looking for this feature..

@tovinayv

This comment has been minimized.

Copy link

tovinayv commented May 8, 2018

Is there any ETA for this?

@mistic

This comment has been minimized.

Copy link
Contributor Author

mistic commented May 29, 2018

( @aendrew @masayuki0812 @kt3k ) any plans to ever release this? It looks like it's a very requested feature 😃

@mageshveeraa

This comment has been minimized.

Copy link

mageshveeraa commented Jul 31, 2018

@aendrew @masayuki0812 @kt3k @mistic When will this be released? I wanted this feature.

@kt3k

This comment has been minimized.

Copy link
Member

kt3k commented Aug 3, 2018

I created another PR to fit this change to the current code base. #2439

Could anyone check the behavior on a sample page?

@kt3k kt3k referenced this pull request Aug 5, 2018

Closed

Drag to Zoom #1485

@kt3k

This comment has been minimized.

Copy link
Member

kt3k commented Aug 7, 2018

The change is merged as #2439.

@kt3k kt3k closed this Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment