New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resizing of background arcs of gauge chart. #2417

Merged
merged 1 commit into from Jul 24, 2018

Conversation

Projects
None yet
2 participants
@kt3k
Copy link
Member

kt3k commented Jul 21, 2018

Inspired by #2410, I changed the timing of merge to after attr('class') call and before attr('d') call.

The background arcs seem resizing and the events on arcs seem working.

@rahul-winner @1Jesper1
How do you think?


This closes #2409

@kt3k kt3k force-pushed the fix2409 branch from bd810fc to e707a64 Jul 23, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 23, 2018

Codecov Report

Merging #2417 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2417   +/-   ##
=======================================
  Coverage   80.75%   80.75%           
=======================================
  Files          54       54           
  Lines        4246     4246           
=======================================
  Hits         3429     3429           
  Misses        817      817
Impacted Files Coverage Δ
src/arc.js 73.95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa49e6d...e707a64. Read the comment docs.

@kt3k

This comment has been minimized.

Copy link
Member Author

kt3k commented Jul 24, 2018

refs: #2410.

@kt3k kt3k merged commit f5b6f30 into master Jul 24, 2018

2 checks passed

ci/circleci: test Your tests passed on CircleCI!
Details
codecov/project 80.75% (+0%) compared to aa49e6d
Details

@kt3k kt3k deleted the fix2409 branch Jul 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment