Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix resizing of background arcs of gauge chart. #2417
Conversation
kt3k
referenced this pull request
Jul 21, 2018
Closed
Fixing 2409 : Calling merge on backgroundArc before setting 'd' attribute. #2410
kt3k
force-pushed the
fix2409
branch
from
bd810fc
to
e707a64
Jul 23, 2018
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Jul 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #2417 +/- ##
=======================================
Coverage 80.75% 80.75%
=======================================
Files 54 54
Lines 4246 4246
=======================================
Hits 3429 3429
Misses 817 817
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
refs: #2410. |
kt3k
merged commit f5b6f30
into
master
Jul 24, 2018
kt3k
deleted the
fix2409
branch
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kt3k commentedJul 21, 2018
Inspired by #2410, I changed the timing of merge to after
attr('class')call and beforeattr('d')call.The background arcs seem resizing and the events on arcs seem working.
@rahul-winner @1Jesper1
How do you think?
This closes #2409