Add zoom type 'drag' option (based on #1500) #2439
Conversation
@kt3k the code looks okay and the features are there. I think we just should include the |
…default zoom behavior. Added uncorrect removed files. Fixed build files permissions. Fixed visibility property spelling. Fixed bug on returned zoom domain in 'onzoomend' event. Prevent a drag from a single click. removed fix for false click. Fixed bug in update zoom when zoom type is drag.
Codecov Report
@@ Coverage Diff @@
## master #2439 +/- ##
==========================================
- Coverage 80.75% 80.48% -0.28%
==========================================
Files 54 54
Lines 4246 4279 +33
==========================================
+ Hits 3429 3444 +15
- Misses 817 835 +18
Continue to review full report at Codecov.
|
@kt3k perfect! I think it's ready to merge whenever you want |
@mistic Thanks for confirming! |
No problem @kt3k :) I believe this will add value to c3js! Thanks for the effort on this. |
@mageshveeraa i have the same problem, did you find a solution for that? |
@mageshveeraa I confirm the bug, and I think that multi level zoom should be the behavior @kt3k @mistic I also found that zoom.enable is not working with this type of zoom You can try it in https://c3js.org/samples/interaction_zoom_by_drag.html Thanks |
@EliasC10 No, I didn't find the solution yet. Now I am using zoom by scroll only. @Federico-G Yes, I mean multi-level zoom behavior is not working. |
This PR is a continuation of #1500. #1500 is not mergeable because of d3's breaking changes and c3's refactoring. I did the following to fit the feature to the current code base.
zoom.disableDefaultBahavior: true
The preview of this change is available here (circleci artifact)
@mistic
Could you check if the above page's behavior reflects your original idea of the feature?