Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix .selected() api not working #2584

Merged
merged 6 commits into from Mar 22, 2019

Conversation

Projects
None yet
3 participants
@LiaanM
Copy link
Contributor

commented Mar 13, 2019

Fixes #2477
d3 selection changed in V4, now returning object not array.
.nodes() can be called on selection object to return array from selection object.

Added basic test in drag-spec to test selected api with and without targetId.

LiaanM added some commits Mar 11, 2019

Fix selected api not working.
d3 selection changed in V4, now returning object not array.
.nodes() can be called to return array from selection object.

Signed-off-by: liaan <liaan@jerichosystems.co.za>
Removed merge and unnecessary map.
Signed-off-by: liaan <liaan@jerichosystems.co.za>
Fix selected api not working.
d3 selection changed in V4, now returning object not array.
.nodes() can be called to return array from selection object.

Signed-off-by: liaan <liaan@jerichosystems.co.za>
Removed swap file
Signed-off-by: liaan <liaan@jerichosystems.co.za>
Implemented basic selected api test in drag functionality tests.
Signed-off-by: liaan <liaan@jerichosystems.co.za>
Added test for selected with targetId filter
Signed-off-by: liaan <liaan@jerichosystems.co.za>
@codecov-io

This comment has been minimized.

Copy link

commented Mar 13, 2019

Codecov Report

Merging #2584 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2584      +/-   ##
==========================================
+ Coverage   80.54%   80.63%   +0.09%     
==========================================
  Files          54       54              
  Lines        4282     4282              
==========================================
+ Hits         3449     3453       +4     
+ Misses        833      829       -4
Impacted Files Coverage Δ
src/api.selection.js 18.91% <100%> (+10.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e03b8...10d2cc9. Read the comment docs.

@kt3k

kt3k approved these changes Mar 22, 2019

Copy link
Member

left a comment

Thanks! Confirmed this fixes the issue. LGTM

@kt3k kt3k merged commit 5a599dd into c3js:master Mar 22, 2019

3 checks passed

ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
circleci/htdocs preview build succes!
Details

@LiaanM LiaanM deleted the LiaanM:bugfix-selected branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.