Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style empty points in line charts via CSS #2693

Merged
merged 1 commit into from Aug 25, 2019

Conversation

@panthony
Copy link
Contributor

commented Aug 20, 2019

An up to date version of #1992

I'll merge this in my fork because it looks neat, I'll leave you to decide if you want this in the main repository.

The culprit is that currentColor is not supported by IE8, in my case I do not care, maybe some will.

Although I'm not sure how well IE8 is supported at the moment (maybe not at all.).

…e color for stroke via css

(cherry picked from commit c67ca83)
@codecov-io

This comment has been minimized.

Copy link

commented Aug 20, 2019

Codecov Report

Merging #2693 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2693   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files          59       59           
  Lines        4633     4633           
=======================================
  Hits         3754     3754           
  Misses        879      879
Impacted Files Coverage Δ
src/shape.line.js 71.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4163be5...3c07c17. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

commented Aug 20, 2019

Codecov Report

Merging #2693 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2693   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files          59       59           
  Lines        4633     4633           
=======================================
  Hits         3754     3754           
  Misses        879      879
Impacted Files Coverage Δ
src/shape.line.js 71.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4163be5...3c07c17. Read the comment docs.

@kt3k
kt3k approved these changes Aug 25, 2019
Copy link
Member

left a comment

Thanks. This makes sense to me.

I think we can safely ignore IE <= 10 now.

I feel some websites still try to support IE11, but in that case we should recommend the use of c3 v0.4.24 because D3 v5 already dropped the support of IE, so c3 v0.4.24 was probably the last version which supported IE well. I think it's ok for the latest version of c3 to only support modern browsers.

@kt3k kt3k merged commit 71c25cf into c3js:master Aug 25, 2019
4 checks passed
4 checks passed
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: test_on_node10 Your tests passed on CircleCI!
Details
ci/circleci: test_on_node8 Your tests passed on CircleCI!
Details
circleci/htdocs preview build succes!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.