Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Minor change to prevent gcc -Weffc++ warnings. #4

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

uliklank commented Apr 15, 2013

Hi c42f,

I like your tool, thanks for that!
I did not know that there is such a small implementation to use std::string with the s/printf syntax, which I prefer over std::stringstream.

We use in our project -Weffc++ and usually build warnings free. I thought instead of branching here permanently, I send you the two lines to prevent the warnings as pull request, perhaps you want to apply it.

Cheers
Uli

Owner

c42f commented Apr 15, 2013

Thanks for the suggestion, I'm happy to help people avoid warnings if the changes are small. I have merged the patch with some modifications to the placement of the declarations so that they appear lower down in the class (away from the public bits). Cheers!

@c42f c42f closed this Apr 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment