Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git:// --> https:// for v8-profiler dependency #10

Closed
nemtsov opened this issue Jun 19, 2012 · 9 comments
Closed

git:// --> https:// for v8-profiler dependency #10

nemtsov opened this issue Jun 19, 2012 · 9 comments

Comments

@nemtsov
Copy link

nemtsov commented Jun 19, 2012

For us—poor souls behind a proxy—can you please switch to using: https://github.com/c4milo/v8-profiler.git (as opposed to git://) in the profile.json

@c4milo
Copy link
Owner

c4milo commented Jun 20, 2012

sadly, npm doesn't work if I do this change :(

@nemtsov
Copy link
Author

nemtsov commented Jun 20, 2012

That is unfortunate. Do you think it's worth releasing your fork as "v8-profiler-4-webkit-devtools-agent" on npm? That also has the added advantage of locking-in a specific version of the v8-profiler into a version of the devtools.

@c4milo
Copy link
Owner

c4milo commented Jun 20, 2012

I was thinking to include in node-webkit-agent only the specific functions
it's using from v8-profiler, since they are really few. As for your current
issue, indeed, publishing in npm under a different name make sense for now.
I'll do that as soon as I can have some spare time.

On Wed, Jun 20, 2012 at 3:28 PM, Yuriy Nemtsov <
reply@reply.github.com

wrote:

That is unfortunate. Do you think it's worth releasing your fork as
"v8-profiler-4-webkit-devtools-agent" on npm? That also has the added
advantage of locking-in a specific version of the v8-profiler into a
version of the devtools.


Reply to this email directly or view it on GitHub:
#10 (comment)

Camilo Aguilar
Software Engineer

@c4milo
Copy link
Owner

c4milo commented Jan 18, 2013

@nemtsov, do you still need this?

@nemtsov
Copy link
Author

nemtsov commented Jan 18, 2013

I'm using my local fork, so—not desperately :)
But I'd love to switch to your version.

@c4milo
Copy link
Owner

c4milo commented Jan 18, 2013

hehe, smart. I'm just wondering if npm is now able to pull http dependencies. I'll test that again and keep you posted.

@mhart
Copy link

mhart commented May 16, 2013

How about:

https://github.com/c4milo/v8-profiler/archive/master.tar.gz

(or whatever tag/version you want)

@yocontra
Copy link

You can do this yourself btw

git config --global url.https://github.com/.insteadOf git://github.com/

@c4milo
Copy link
Owner

c4milo commented Nov 15, 2013

This is fully addressed in b3c749a and version 0.2.0 in NPM.

@c4milo c4milo closed this as completed Nov 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants