Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

git:// --> https:// for v8-profiler dependency #10

Closed
nemtsov opened this Issue · 9 comments

4 participants

@nemtsov

For us—poor souls behind a proxy—can you please switch to using: https://github.com/c4milo/v8-profiler.git (as opposed to git://) in the profile.json

@c4milo
Owner

sadly, npm doesn't work if I do this change :(

@nemtsov

That is unfortunate. Do you think it's worth releasing your fork as "v8-profiler-4-webkit-devtools-agent" on npm? That also has the added advantage of locking-in a specific version of the v8-profiler into a version of the devtools.

@c4milo
Owner
@c4milo
Owner

@nemtsov, do you still need this?

@nemtsov

I'm using my local fork, so—not desperately :)
But I'd love to switch to your version.

@c4milo
Owner

hehe, smart. I'm just wondering if npm is now able to pull http dependencies. I'll test that again and keep you posted.

@mhart

How about:

https://github.com/c4milo/v8-profiler/archive/master.tar.gz

(or whatever tag/version you want)

@contra

You can do this yourself btw

git config --global url.https://github.com/.insteadOf git://github.com/

@c4milo
Owner

This is fully addressed in b3c749a and version 0.2.0 in NPM.

@c4milo c4milo closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.