Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building on Windows 7 x64 #47

Merged
merged 1 commit into from Feb 1, 2014
Merged

Fix building on Windows 7 x64 #47

merged 1 commit into from Feb 1, 2014

Conversation

cspotcode
Copy link
Contributor

Related to #46.

EDIT: I forgot to mention, you should probably switch the order of #includes in cpu_profiler.h as well, and maybe add #include <node.h> to all your .cc files. I'm not sure.

- tried the fix listed here, and it worked: https://groups.google.com/forum/#!topic/nodejs/onA0S01INtw
- have not proved that it will work everywhere, but it's worth a shot
@c4milo
Copy link
Owner

c4milo commented Feb 1, 2014

Good catch, thank you!

c4milo added a commit that referenced this pull request Feb 1, 2014
Fix building on Windows 7 x64
@c4milo c4milo merged commit bab5639 into c4milo:master Feb 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants