Skip to content

containers must never throw #4

Closed
fjakobs opened this Issue May 23, 2012 · 3 comments

3 participants

@fjakobs
Cloud9 member
fjakobs commented May 23, 2012

The container throws exceptions in a couple of places. This is bad since there is no way to catch those errors. This is especially problematic since we use architect as a library. The exceptions must be converted into error objects and passed the the callback of createApp().

https://github.com/c9/architect/blob/master/container.js#L52

@creationix creationix was assigned May 23, 2012
@creationix

Good idea. I'm currently refactoring the API for vfs-ssh to make more sense.

@creationix

Removed containers from architect. Since there are no containers anymore, they can't throw. :)

@creationix creationix closed this Jun 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.