Fixing issues with arguments with optional values lonely in a command. #10

Merged
merged 1 commit into from Feb 28, 2014

Conversation

Projects
None yet
2 participants
Contributor

igorsantos07 commented Feb 27, 2014

This closes #9.

I've added what @dlussky suggested and extended the fix to takeOptionValue as well. Lastly, be default the option with no value would get a "null" as value, what makes it behave as if it wasn't set. Thus, I'm setting it to "true" if it's there but there's no value. Does that make sense? Is there another place where this change should be replicated?

c9s added a commit that referenced this pull request Feb 28, 2014

Merge pull request #10 from igorsantos07/master
Fixing issues with arguments with optional values lonely in a command.

@c9s c9s merged commit c235453 into c9s:master Feb 28, 2014

1 check passed

default The Travis CI build passed
Details
Contributor

igorsantos07 commented Mar 2, 2014

Thanks @c9s! Would you mind releasing a new tag so we can update accordingly?

Owner

c9s commented Mar 2, 2014

Sure!

Owner

c9s commented Mar 2, 2014

1.2.5 just got released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment