New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpan pull request challenge] patch for issue #8 & kwalitee fixes #20

Merged
merged 2 commits into from Jul 26, 2015

Conversation

Projects
None yet
2 participants
@laouji
Contributor

laouji commented Jul 26, 2015

Hi! I was assigned your repository for the CPAN Pull Request Challenge. I've made a few minor changes that should hopefully fix some of your CPANTs fails.

Also there was an issue reported by one of your users that I was able to reproduce, so I added a patch for that as well.

Here's a summary of the suggested changes:

  • Ensure that the plugin install directory is properly created if it doesn't already exist. ref: #8
  • Remove bareword file handles (see p.202,204 of Damian Conway's Perl Best Practices)
  • Add a pod test and fix pod errors to improve your kwalitee score

If you have any suggestions for things you'd like me to change, let me know!

@c9s

This comment has been minimized.

Show comment
Hide comment
@c9s

c9s Jul 26, 2015

Owner

Looks good! thanks!

Owner

c9s commented Jul 26, 2015

Looks good! thanks!

c9s added a commit that referenced this pull request Jul 26, 2015

Merge pull request #20 from laouji/pr-challenge
[cpan pull request challenge] patch for issue #8 & kwalitee fixes

@c9s c9s merged commit 0d1d45e into c9s:master Jul 26, 2015

@laouji laouji deleted the laouji:pr-challenge branch Jul 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment